Skip to content

Commit

Permalink
Small tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
NicoZelaya committed Jan 24, 2020
1 parent be245fa commit 1683bb7
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
21 changes: 16 additions & 5 deletions src/services/splitChanges/offline/browser.js
@@ -1,7 +1,17 @@
import { isObject, forOwn } from '../../../utils/lang';
import parseCondition from './parseCondition';

let previousMock = { '':1 };
let previousMock = { 'emptyMock': 1 };

function hasTreatmentChanged(prev, curr) {
if (typeof prev !== typeof curr) return true;

if (typeof prev === 'string') { // strings treatments, just compare
return prev !== curr;
} else { // has treatment and config, compare both
return prev.treatment !== curr.treatment || prev.config !== curr.config;
}
}

function mockUpdated(currentData) {
const names = Object.keys(currentData);
Expand All @@ -14,11 +24,12 @@ function mockUpdated(currentData) {

return names.some(name => {
const newSplit = !previousMock[name];
const newTreatment = previousMock[name] !== currentData[name];

previousMock = currentData;
const newTreatment = hasTreatmentChanged(previousMock[name], currentData[name]);
const changed = newSplit || newTreatment;

return newSplit || newTreatment;
if (changed) previousMock = currentData;

return changed;
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/services/splitChanges/offline/node.js
Expand Up @@ -24,7 +24,7 @@ const log = logFactory('splitio-offline:splits-fetcher');

const DEFAULT_FILENAME = '.split';

let previousMock = '~~~~~';
let previousMock = 'NO_MOCK_LOADED';

function configFilesPath(config = {}) {
let configFilePath = config.features;
Expand Down

0 comments on commit 1683bb7

Please sign in to comment.