Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP CS Fix #216

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
55 changes: 55 additions & 0 deletions .php_cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<?php

declare(strict_types=1);

return PhpCsFixer\Config::create()
->setCacheFile(__DIR__ . '/.php_cs.cache')
->setRiskyAllowed(true)
->setRules([
'@PSR2' => true,
'binary_operator_spaces' => [
'default' => null,
'operators' => [
'|' => 'single_space',
'!==' => 'single_space',
'!=' => 'single_space',
'==' => 'single_space',
'===' => 'single_space',
],
],
'ordered_class_elements' => true,
'trailing_comma_in_multiline_array' => false,
'declare_strict_types' => true,
'linebreak_after_opening_tag' => true,
'blank_line_after_opening_tag' => true,
'single_quote' => true,
'lowercase_cast' => true,
'short_scalar_cast' => true,
'no_leading_import_slash' => true,
'declare_equal_normalize' => [
'space' => 'none',
],
'new_with_braces' => true,
'no_blank_lines_after_phpdoc' => true,
'single_blank_line_before_namespace' => true,
'visibility_required' => ['property', 'method', 'const'],
'ternary_operator_spaces' => true,
'unary_operator_spaces' => true,
'return_type_declaration' => true,
'concat_space' => [
'spacing' => 'one',
],
'no_useless_else' => true,
'no_useless_return' => true,
'phpdoc_separation' => false,
'yoda_style' => false,
'void_return' => true,
])
->setFinder(
PhpCsFixer\Finder::create()
->in(__DIR__)
->exclude([
'vendor',
'bin',
])
);
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ install:

script:
- vendor/bin/phpunit --coverage-clover=coverage.xml
- vendor/bin/phpcs -n --report=code --standard=PSR12 --colors tests src
- vendor/bin/phpcs -n --standard=PSR2 --colors src tests
alexndr-novikov marked this conversation as resolved.
Show resolved Hide resolved

after_success:
Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"cycle/proxy-factory": "^1.0.3",
"phpunit/phpunit": "~7.0",
"mockery/mockery": "^1.1",
"squizlabs/php_codesniffer": "^3.4"
"squizlabs/php_codesniffer": "^3.5.0",
"friendsofphp/php-cs-fixer": "^v2.15.3"
},
"autoload": {
"files": [
Expand Down
2 changes: 1 addition & 1 deletion functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function bind(string $alias, array $parameters = [])
*
* @param mixed $value
*/
function dumprr($value)
function dumprr($value): void
{
dump($value, Dumper::ERROR_LOG);
}
Expand Down
23 changes: 12 additions & 11 deletions src/Bootloader/CommandBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand Down Expand Up @@ -37,15 +38,15 @@
*/
final class CommandBootloader extends Bootloader
{
const DEPENDENCIES = [
public const DEPENDENCIES = [
ConsoleBootloader::class,
];

/**
* @param ConsoleBootloader $console
* @param Container $container
*/
public function boot(ConsoleBootloader $console, Container $container)
public function boot(ConsoleBootloader $console, Container $container): void
{
$console->addCommand(Console\Command\ConfigureCommand::class);
$console->addCommand(Console\Command\UpdateCommand::class);
Expand Down Expand Up @@ -106,7 +107,7 @@ private function configureExtensions(ConsoleBootloader $console, Container $cont
/**
* @param ConsoleBootloader $console
*/
private function configureDatabase(ConsoleBootloader $console)
private function configureDatabase(ConsoleBootloader $console): void
{
$console->addCommand(Database\ListCommand::class);
$console->addCommand(Database\TableCommand::class);
Expand All @@ -116,7 +117,7 @@ private function configureDatabase(ConsoleBootloader $console)
* @param ConsoleBootloader $console
* @param ContainerInterface $container
*/
private function configureCycle(ConsoleBootloader $console, ContainerInterface $container)
private function configureCycle(ConsoleBootloader $console, ContainerInterface $container): void
{
$console->addCommand(Cycle\UpdateCommand::class);

Expand All @@ -135,16 +136,16 @@ private function configureCycle(ConsoleBootloader $console, ContainerInterface $
/**
* @param ConsoleBootloader $console
**/
private function configureTranslator(ConsoleBootloader $console)
private function configureTranslator(ConsoleBootloader $console): void
{
$console->addCommand(Translator\IndexCommand::class);
$console->addCommand(Translator\ExportCommand::class);
$console->addCommand(Translator\ResetCommand::class);

$console->addConfigureSequence(
function (FilesInterface $files, TranslatorConfig $config, OutputInterface $output) {
function (FilesInterface $files, TranslatorConfig $config, OutputInterface $output): void {
$files->ensureDirectory($config->getLocaleDirectory($config->getDefaultLocale()));
$output->writeln("<info>The default locale directory has been ensured.</info>");
$output->writeln('<info>The default locale directory has been ensured.</info>');
},
'<fg=magenta>[i18n]</fg=magenta> <fg=cyan>ensure default locale directory...</fg=cyan>'
);
Expand All @@ -158,7 +159,7 @@ function (FilesInterface $files, TranslatorConfig $config, OutputInterface $outp
/**
* @param ConsoleBootloader $console
*/
private function configureViews(ConsoleBootloader $console)
private function configureViews(ConsoleBootloader $console): void
{
$console->addCommand(Views\ResetCommand::class);
$console->addCommand(Views\CompileCommand::class);
Expand All @@ -172,7 +173,7 @@ private function configureViews(ConsoleBootloader $console)
/**
* @param ConsoleBootloader $console
*/
private function configureMigrations(ConsoleBootloader $console)
private function configureMigrations(ConsoleBootloader $console): void
{
$console->addCommand(Migrate\InitCommand::class);
$console->addCommand(Migrate\StatusCommand::class);
Expand All @@ -184,7 +185,7 @@ private function configureMigrations(ConsoleBootloader $console)
/**
* @param ConsoleBootloader $console
*/
private function configureGRPC(ConsoleBootloader $console)
private function configureGRPC(ConsoleBootloader $console): void
{
$console->addCommand(GRPC\GenerateCommand::class);
$console->addCommand(GRPC\ListCommand::class);
Expand All @@ -193,7 +194,7 @@ private function configureGRPC(ConsoleBootloader $console)
/**
* @param ConsoleBootloader $console
*/
private function configureEncrypter(ConsoleBootloader $console)
private function configureEncrypter(ConsoleBootloader $console): void
{
$console->addCommand(Encrypter\KeyCommand::class);
}
Expand Down
13 changes: 7 additions & 6 deletions src/Bootloader/ConsoleBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand Down Expand Up @@ -28,11 +29,11 @@
*/
final class ConsoleBootloader extends Bootloader implements SingletonInterface
{
const DEPENDENCIES = [
public const DEPENDENCIES = [
TokenizerBootloader::class,
];

const SINGLETONS = [
public const SINGLETONS = [
Console::class => Console::class,
LocatorInterface::class => CommandLocator::class
];
Expand All @@ -52,7 +53,7 @@ public function __construct(ConfiguratorInterface $config)
* @param KernelInterface $kernel
* @param ConsoleDispatcher $console
*/
public function boot(KernelInterface $kernel, ConsoleDispatcher $console)
public function boot(KernelInterface $kernel, ConsoleDispatcher $console): void
{
$kernel->addDispatcher($console);

Expand All @@ -69,7 +70,7 @@ public function boot(KernelInterface $kernel, ConsoleDispatcher $console)
/**
* @param string $command
*/
public function addCommand(string $command)
public function addCommand(string $command): void
{
$this->config->modify(
'console',
Expand All @@ -88,7 +89,7 @@ public function addConfigureSequence(
string $header,
string $footer = '',
array $options = []
) {
): void {
$this->config->modify(
'console',
$this->sequence('configure', $sequence, $header, $footer, $options)
Expand All @@ -106,7 +107,7 @@ public function addUpdateSequence(
string $header,
string $footer = '',
array $options = []
) {
): void {
$this->config->modify(
'console',
$this->sequence('update', $sequence, $header, $footer, $options)
Expand Down
5 changes: 3 additions & 2 deletions src/Bootloader/Cycle/AnnotatedBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand All @@ -15,14 +16,14 @@

final class AnnotatedBootloader extends Bootloader
{
const DEPENDENCIES = [
public const DEPENDENCIES = [
SchemaBootloader::class
];

/**
* @param SchemaBootloader $schema
*/
public function boot(SchemaBootloader $schema)
public function boot(SchemaBootloader $schema): void
{
AnnotationRegistry::registerLoader('class_exists');

Expand Down
9 changes: 5 additions & 4 deletions src/Bootloader/Cycle/CycleBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand Down Expand Up @@ -28,7 +29,7 @@

final class CycleBootloader extends Bootloader
{
const DEPENDENCIES = [
public const DEPENDENCIES = [
DatabaseBootloader::class,
SchemaBootloader::class
];
Expand All @@ -47,9 +48,9 @@ final class CycleBootloader extends Bootloader
* @param FinalizerInterface $finalizer
* @param SchemaInterface|null $schema
*/
public function boot(Container $container, FinalizerInterface $finalizer, SchemaInterface $schema = null)
public function boot(Container $container, FinalizerInterface $finalizer, SchemaInterface $schema = null): void
{
$finalizer->addFinalizer(function () use ($container) {
$finalizer->addFinalizer(function () use ($container): void {
if ($container->hasInstance(ORMInterface::class)) {
$container->get(ORMInterface::class)->getHeap()->clean();
}
Expand All @@ -68,7 +69,7 @@ public function boot(Container $container, FinalizerInterface $finalizer, Schema
* @param Container $container
* @param SchemaInterface $schema
*/
public function bindRepositories(Container $container, SchemaInterface $schema)
public function bindRepositories(Container $container, SchemaInterface $schema): void
{
foreach ($schema->getRoles() as $role) {
$repository = $schema->define($role, SchemaInterface::REPOSITORY);
Expand Down
3 changes: 2 additions & 1 deletion src/Bootloader/Cycle/ProxiesBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand All @@ -17,7 +18,7 @@

final class ProxiesBootloader extends Bootloader
{
const DEPENDENCIES = [
public const DEPENDENCIES = [
CycleBootloader::class
];

Expand Down
5 changes: 3 additions & 2 deletions src/Bootloader/Cycle/SchemaBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand Down Expand Up @@ -29,7 +30,7 @@ final class SchemaBootloader extends Bootloader implements Container\SingletonIn
TokenizerBootloader::class
];

const BINDINGS = [
public const BINDINGS = [
SchemaInterface::class => [self::class, 'schema'],
Generator\GenerateRelations::class => [self::class, 'relationGenerator'],
];
Expand Down Expand Up @@ -71,7 +72,7 @@ public function __construct(Container $container)
* @param string $group
* @param mixed $generator
*/
public function addGenerator(string $group, $generator)
public function addGenerator(string $group, $generator): void
{
$this->generators[$group][] = $generator;
}
Expand Down
7 changes: 4 additions & 3 deletions src/Bootloader/Database/DatabaseBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand All @@ -19,11 +20,11 @@

final class DatabaseBootloader extends Bootloader implements SingletonInterface
{
const SINGLETONS = [
public const SINGLETONS = [
DatabaseProviderInterface::class => DatabaseManager::class,
];

const BINDINGS = [
public const BINDINGS = [
DatabaseInterface::class => Database::class
];

Expand All @@ -41,7 +42,7 @@ public function __construct(ConfiguratorInterface $config)
/**
* Init database config.
*/
public function boot()
public function boot(): void
{
$this->config->setDefaults('database', [
'default' => 'default',
Expand Down
5 changes: 3 additions & 2 deletions src/Bootloader/Database/DisconnectsBootloader.php
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Spiral Framework.
*
Expand All @@ -23,9 +24,9 @@ final class DisconnectsBootloader extends Bootloader
* @param FinalizerInterface $finalizer
* @param ContainerInterface $container
*/
public function boot(FinalizerInterface $finalizer, ContainerInterface $container)
public function boot(FinalizerInterface $finalizer, ContainerInterface $container): void
{
$finalizer->addFinalizer(function () use ($container) {
$finalizer->addFinalizer(function () use ($container): void {
/** @var DatabaseManager $dbal */
$dbal = $container->get(DatabaseManager::class);
foreach ($dbal->getDrivers() as $driver) {
Expand Down