Adapt for okhttp3 4.x #1653
Closed
Adapt for okhttp3 4.x #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droustchev-pd
force-pushed
the
upgrade-okhttp-4.x
branch
2 times, most recently
from
cf2fa83
to
64ce264
Compare
dbyron-sf
reviewed
May 11, 2023
...ns/src/main/kotlin/com/netflix/spinnaker/gate/plugins/web/publish/PluginPublishController.kt
Outdated
Show resolved
Hide resolved
droustchev-pd
force-pushed
the
upgrade-okhttp-4.x
branch
from
64ce264
to
8de0c39
Compare
droustchev-pd
force-pushed
the
upgrade-okhttp-4.x
branch
from
8de0c39
to
9a8f695
Compare
dbyron-sf
reviewed
May 18, 2023
| @@ -135,7 +136,7 @@ class ProxyController( | |||
|
|
|||
| val body = if (HttpMethod.permitsRequestBody(method) && request.contentType != null) { | |||
| RequestBody.create( | |||
There was a problem hiding this comment.
These few lines can become:
request.reader.lines().collect(Collectors.joining(System.lineSeparator())).toRequestBody(request.contentType.toMediaType())
|
included in #1667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on spinnaker/kork#1044, where OkHttp was updated to the latest 4.x version. It was primarily motivated by square/okhttp#6738 and is based on the official upgrade instructions: https://square.github.io/okhttp/changelogs/upgrading_to_okhttp_4/