Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken pip installer by forcing it to detect macOS 11 as 11.0 and not 10.16 #4359

Merged

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Feb 2, 2024

Description

This was a really weird bug to investigate!! General background info references:

Specific to onnxruntime:

The above issue has only become relevant for SCT because one of its dependencies, onnxruntime switched to wheels that specify macosx_11_0 in the wheel's name instead of the previous macosx_10_15. So, we need the compatibility fix to install the newest onnxruntime wheels, at least until pip fixes this upstream by vendoring a newer version of packaging:

Linked issues

Fixes #4352.

Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This macOS 10.16 == 11.0 thing is such a weird version number hack on the part of Apple. Thanks for tracking it down, and for all the references!

@joshuacwnewton joshuacwnewton merged commit b15626f into master Feb 5, 2024
24 checks passed
@joshuacwnewton joshuacwnewton deleted the jn/4352-patch-pip-packaging-bug-macos-10_16-11_0 branch February 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos CI runners fail to install onnxruntime==1.17.0 wheels with macosx_11_0 version specifiers
2 participants