Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Timer with progress #1554

Merged
merged 8 commits into from Jan 17, 2018
Merged

Fix Timer with progress #1554

merged 8 commits into from Jan 17, 2018

Conversation

poquirion
Copy link
Contributor

Fix #1507

@jcohenadad
Copy link
Member

I tested poq_issue_1507_progress/32a1bf244dc13569d53ae9ec6550ebd2392151c3

The issue with the timer is fixed. Tested with:

sct_process_segmentation -i t2_seg.nii.gz -p shape

However, this issue remain:
#1507 (comment)

@poquirion
Copy link
Contributor Author

Should be good to go now

@poquirion poquirion added bug category: fixes an error in the code card:TO_REVIEW labels Dec 14, 2017
@jcohenadad jcohenadad added this to the 3.1.1 milestone Jan 15, 2018
@perone
Copy link
Contributor

perone commented Jan 16, 2018

I added tqdm on SCT in the past for some progress bars, estimated time left, etc. I think that it can be easier to use instead of doing this manually.

@jcohenadad jcohenadad merged commit c9766bf into master Jan 17, 2018
@jcohenadad jcohenadad deleted the poq_issue_1507_progress branch January 17, 2018 07:57
@poquirion
Copy link
Contributor Author

We can use tqdm, but we still need to add a wrapper for the logger...
tqdm/tqdm#313

I'll see how to do that best.

@jcohenadad jcohenadad restored the poq_issue_1507_progress branch January 19, 2018 02:50
@jcohenadad jcohenadad deleted the poq_issue_1507_progress branch August 12, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants