-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump google.golang.org/grpc from 1.63.2 to 1.64.0 #5148
Bump google.golang.org/grpc from 1.63.2 to 1.64.0 #5148
Conversation
2231868
to
b06593c
Compare
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.2 to 1.64.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.63.2...v1.64.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
b06593c
to
fa94c71
Compare
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some spots we can start using NewClient already.
pkg/agent/client/nodeconn_test.go
Outdated
@@ -35,7 +35,8 @@ func newTestConn(t *testing.T) *grpc.ClientConn { | |||
}) | |||
client.dialContext = func(ctx context.Context, addr string, opts ...grpc.DialOption) (*grpc.ClientConn, error) { | |||
// make a normal grpc dial but without any of the provided options that may cause it to fail | |||
return grpc.DialContext(ctx, addr, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
return grpc.DialContext(ctx, addr, //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -1235,7 +1235,7 @@ func setupTestWithManager(t *testing.T, c Config, manager *FakeManager) *handler | |||
listener, err := net.Listen("tcp", "localhost:0") | |||
require.NoError(t, err) | |||
|
|||
conn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
conn, err := grpc.Dial(listener.Addr().String(), grpc.WithTransportCredentials(insecure.NewCredentials())) //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -331,7 +331,7 @@ func TestListenAndServe(t *testing.T) { | |||
unfederatedConfig := tlsconfig.MTLSClientConfig(unfederatedForeignAdminSVID, ca.X509Bundle(), tlsconfig.AuthorizeID(serverID)) | |||
|
|||
for _, config := range []*tls.Config{unauthenticatedConfig, unauthorizedConfig, unfederatedConfig} { | |||
conn, err := grpc.DialContext(ctx, endpoints.TCPAddr.String(), | |||
conn, err := grpc.DialContext(ctx, endpoints.TCPAddr.String(), //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -60,7 +60,8 @@ func (c *serverClient) start(ctx context.Context) error { | |||
} | |||
|
|||
tlsConfig := tlsconfig.MTLSClientConfig(source, source, tlsconfig.AuthorizeID(c.serverID)) | |||
conn, err := grpc.DialContext(ctx, c.serverAddr, grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))) | |||
conn, err := grpc.DialContext(ctx, c.serverAddr, //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -73,7 +73,7 @@ func printDebugPage(ctx context.Context) error { | |||
} | |||
|
|||
func retrieveDebugPage(ctx context.Context) (string, error) { | |||
conn, err := grpc.Dial(*socketPathFlag, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
conn, err := grpc.Dial(*socketPathFlag, grpc.WithTransportCredentials(insecure.NewCredentials())) //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -40,7 +40,7 @@ func run() error { | |||
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute) | |||
defer cancel() | |||
|
|||
conn, err := grpc.Dial(*socketPathFlag, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
conn, err := grpc.Dial(*socketPathFlag, grpc.WithTransportCredentials(insecure.NewCredentials())) //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -51,7 +51,7 @@ func New(ctx context.Context) *Client { | |||
|
|||
// Create connection | |||
tlsConfig := tlsconfig.MTLSClientConfig(source, source, tlsconfig.AuthorizeAny()) | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))) | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))) //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -70,7 +70,8 @@ func NewInsecure(ctx context.Context) *Client { | |||
tlsConfig := tls.Config{ | |||
InsecureSkipVerify: true, //nolint: gosec // this is intentional for the integration test | |||
} | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, grpc.WithTransportCredentials(credentials.NewTLS(&tlsConfig))) | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -93,7 +94,8 @@ func NewWithCert(ctx context.Context, cert *x509.Certificate, key crypto.Signer) | |||
}, | |||
InsecureSkipVerify: true, //nolint: gosec // this is intentional for the integration test | |||
} | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, grpc.WithTransportCredentials(credentials.NewTLS(&tlsConfig))) | |||
conn, err := grpc.DialContext(ctx, *serverAddrFlag, //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
@@ -161,7 +163,8 @@ func (c *LocalServerClient) Release() { | |||
|
|||
func NewLocalServerClient(ctx context.Context) *LocalServerClient { | |||
flag.Parse() | |||
conn, err := grpc.DialContext(ctx, *serverSocketPathFlag, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
conn, err := grpc.DialContext(ctx, *serverSocketPathFlag, //nolint: staticcheck // It is going to be resolved on #5152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no deprecated options, can this use grpc.NewClient?
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Bumps google.golang.org/grpc from 1.63.2 to 1.64.0.
Release notes
Sourced from google.golang.org/grpc's releases.
Commits
fa274d7
Change version to 1.64.0 (#7218)6b413c8
xds: Surround twoInfof
calls that usepretty.ToJSON
withV(2)
checks (...2dbbcef
resolver/dns: Add docstring to SetMinResolutionInterval (#7217)070d9c7
codes: replace %q to %d in error string when invalid code is an integer (#7188)5d24ee2
xds: store server config for LRS server in xdsresource.ClusterUpdate (#7191)c76f686
advancedTLS: Rename get root certs related pieces (#7207)f591e3b
codec: remove option to suppress setting supported compressors in headers (#7...b4f7947
github: remove dependabot (#7208)0561c78
client: add user-friendly error message of LB policy update timed out (#7206)9d9c1fb
peer: remove change detector test (#7204)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)