Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax test assertions #193

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Relax test assertions #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions v2/spiffetls/spiffetls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,10 @@ func TestClose(t *testing.T) {

// If the connection was really closed, this should fail
_, err = conn.Write([]byte(dataString))
require.EqualError(t, err, "tls: use of closed connection")
require.Error(t, err)

// Connection has been closed already, expect error
require.EqualError(t, conn.Close(), "spiffetls: unable to close TLS connection: tls: use of closed connection")
require.Error(t, conn.Close())

// Close listener
require.NoError(t, listener.Close())
Expand All @@ -449,7 +449,7 @@ func TestClose(t *testing.T) {
require.Error(t, err)

// Listener has been closed already, expect error
require.Contains(t, listener.Close().Error(), "use of closed network connection")
require.Error(t, listener.Close())
}

func setWorkloadAPIResponse(ca *test.CA, s *fakeworkloadapi.WorkloadAPI, spiffeID spiffeid.ID) {
Expand Down