-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building on Windows #191
Conversation
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
.github/workflows/pr_build.yaml
Outdated
# This job is just here to make sure that the other jobs have completed | ||
# and is used as a single job to block PR merge from. GH doesn't have a | ||
# way to say "all jobs from this action", which would be ideal. | ||
success: | ||
needs: [lint, test] | ||
success-linux: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may we put all need in the same job? if we separate between windows/linux, we'll not have a single job that group all.
success:
needs: [lint-linux, test-linux, lint-windows, test-windows]
runs-on: ubuntu-latest
steps:
- name: Shout it out
run: echo SUCCESS
- name: Shout it out - Linux
run: echo SUCCESS - Linux
// +build !windows | ||
|
||
// OS specific error strings | ||
package errstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't my favorite thing, but I think is fine in the short term. I think we should probably change the tests to uses errors.Is
or something to detect the right error condition, but I recognize that is a larger change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. I explored that path and found it out of scope for this PR, but would really like to have it implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @amartinezfayo!
Add support to build go-spiffe on Windows.