Relax test assertions #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current assertions are too coupled to the exact error message produced by the Go net package internals, which can vary between versions and platforms. We don't really need this strong of an assertion. All we need to know is that the Close() method was wired through appropriately. Signed-off-by: Andrew Harding <aharding@vmware.com>
|
I'm going to merge this even though there are other windows CI/CD failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current assertions are too coupled to the exact error message
produced by the Go net package internals, which can vary between
versions and platforms.
We don't really need this strong of an assertion. All we need to know is
that the Close() method was wired through appropriately.
Signed-off-by: Andrew Harding aharding@vmware.com