Support building on Windows #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
MarcosDY
reviewed
Apr 14, 2022
.github/workflows/pr_build.yaml
Outdated
| # This job is just here to make sure that the other jobs have completed | ||
| # and is used as a single job to block PR merge from. GH doesn't have a | ||
| # way to say "all jobs from this action", which would be ideal. | ||
| success: | ||
| needs: [lint, test] | ||
| success-linux: |
There was a problem hiding this comment.
may we put all need in the same job? if we separate between windows/linux, we'll not have a single job that group all.
success:
needs: [lint-linux, test-linux, lint-windows, test-windows]
runs-on: ubuntu-latest
steps:
- name: Shout it out
run: echo SUCCESS
- name: Shout it out - Linux
run: echo SUCCESS - Linux
azdagron
reviewed
Apr 14, 2022
| // +build !windows | ||
|
|
||
| // OS specific error strings | ||
| package errstrings |
There was a problem hiding this comment.
This isn't my favorite thing, but I think is fine in the short term. I think we should probably change the tests to uses errors.Is or something to detect the right error condition, but I recognize that is a larger change.
There was a problem hiding this comment.
Yes, I agree. I explored that path and found it out of scope for this PR, but would really like to have it implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to build go-spiffe on Windows.