improve metric package #937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
requested review from
weizhoublue,
ty-dc,
yulng,
bzsuni and
iiiceoo
as code owners
weizhoublue
previously approved these changes
Oct 25, 2022
Icarus9913
force-pushed
the
feat/wk/metric-improve
branch
from
3cc722d
to
4df31c6
Compare
Icarus9913
added
pr/ready-review
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
=======================================
Coverage 82.09% 82.09%
=======================================
Files 8 8
Lines 592 592
=======================================
Hits 486 486
Misses 87 87
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. |
Icarus9913
force-pushed
the
feat/wk/metric-improve
branch
2 times, most recently
from
9fa579c
to
12edac3
Compare
weizhoublue
reviewed
Oct 31, 2022
pkg/metric/metrics_instance.go
Outdated
|
|
||
| // spiderpool controller IP GC metrics name | ||
| ip_gc_total_counts = "ip_gc_total_counts" | ||
| ip_gc_failure_counts = "ip_gc_failure_counts" | ||
|
|
||
| ippool_left_ip_counts = "ippool_left_ip_counts" |
weizhoublue
reviewed
Oct 31, 2022
pkg/metric/metrics_instance.go
Outdated
|
|
||
| // spiderpool controller IP GC metrics name | ||
| ip_gc_total_counts = "ip_gc_total_counts" | ||
| ip_gc_failure_counts = "ip_gc_failure_counts" | ||
|
|
||
| ippool_left_ip_counts = "ippool_left_ip_counts" | ||
| subnet_left_ip_counts = "subnet_left_ip_counts" |
There was a problem hiding this comment.
subnet_total_ip_counts
subnet_free_ip_counts
weizhoublue
reviewed
Oct 31, 2022
pkg/metric/metrics_instance.go
Outdated
| ippool_left_ip_counts = "ippool_left_ip_counts" | ||
| subnet_left_ip_counts = "subnet_left_ip_counts" | ||
|
|
||
| subnet_ips_apply_counts = "subnet_ips_apply_counts" |
Icarus9913
force-pushed
the
feat/wk/metric-improve
branch
2 times, most recently
from
77b3c1d
to
01d0851
Compare
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
Icarus9913
force-pushed
the
feat/wk/metric-improve
branch
from
01d0851
to
2006c4e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it easy to use the otel gauge
Reference:
https://github.com/open-telemetry/opentelemetry-go/blob/042d938989bfe4960c96328328f1f324bc72bdf3/example/prometheus/main.go#L61
open-telemetry/opentelemetry-go#3168
Signed-off-by: Icarus9913 icaruswu66@qq.com