Skip to content

Commit

Permalink
DevOps: Unpin version of setuptools
Browse files Browse the repository at this point in the history
This reverts commit 865c30e.
The bug has been fixed in `setuptools==65.6.2`, see:
pypa/setuptools#3693
  • Loading branch information
sphuber committed Nov 24, 2022
1 parent 3cc681c commit c774a67
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,8 @@ jobs:
run: sudo apt update && sudo apt install postgresql graphviz

- name: Upgrade pip and setuptools
# Install specific version of setuptools, because 65.6.0 breaks a number of packages, such as numpy
run: |
pip install --upgrade pip
pip install setuptools==65.5.0
pip install --upgrade pip setuptools
pip --version
- name: Build pymatgen with compatible numpy
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/test-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,8 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Upgrade pip and setuptools
# Install specific version of setuptools, because 65.6.0 breaks a number of packages, such as numpy
run: |
pip install --upgrade pip
pip install setuptools==65.5.0
pip install --upgrade pip setuptools
pip --version
- name: Create environment from requirements file.
Expand Down Expand Up @@ -231,10 +229,8 @@ jobs:

- name: Upgrade pip and setuptools
# It is crucial to update `setuptools` or the installation of `pymatgen` can break
# Install specific version of setuptools, because 65.6.0 breaks a number of packages, such as numpy
run: |
pip install --upgrade pip
pip install setuptools==65.5.0
pip install --upgrade pip setuptools
pip --version
- name: Install aiida-core
Expand Down

0 comments on commit c774a67

Please sign in to comment.