Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirecting links #150

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stevepiercy
Copy link

See #149.

Partially fixes that issue, except for linked images, and the curl command, which could be added to linkcheck_ignore.

@pradyunsg
Copy link
Collaborator

linkcheck_ignore

Could you go ahead and add those into this configuration variable?

@stevepiercy
Copy link
Author

@pradyunsg I would if I knew where the conf.py exists. Is it in another repo?

Also I would only add http://someurl/ to linkcheck_ignore.

I am not sure whether you would prefer to use locally hosted images instead of a third-party which can change its URLs without notice and potentially redirect to a link farm or other nefarious site.

Please let me know. Thank you!

@pradyunsg
Copy link
Collaborator

Here ya go: https://github.com/sphinx-themes/sphinx-themes.org/blob/master/src/templates/conf.template.py

a third-party which can change its URLs without notice

It's not without notice -- the link is explicitly to a redirect intentionally, since you get a picture of a different cute animal each day. :)

potentially redirect to a link farm or other nefarious site.

Well, Unsplash is a reputable site and, AFAICT, a stable business. This isn't a concern I'd have about this.

Please do add the unsplash links to the linkcheck_ignore.

@stevepiercy
Copy link
Author

Added someurl and unsplash to linkcheck_ignore template in 749ad9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants