Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re)load the page for each screen size #148

Merged
merged 2 commits into from
May 13, 2024

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented May 5, 2024

For now, this is just an experiment, I don't know yet if it will work as intended.

I don't know how the handling of progress should be adapted.

@mgeier
Copy link
Contributor Author

mgeier commented May 5, 2024

OK, this works as expected.

Maybe I should explain:

My insipid theme shows a sidebar by default if the page is opened on a huge screen.
However, it is not shown when opened on a small screen and the window is made larger afterwards.

Since the screenshot generation works like the latter, the large insipid screenshot doesn't look like it would actually look on a large screen.

@mgeier mgeier marked this pull request as ready for review May 5, 2024 19:33
@mgeier
Copy link
Contributor Author

mgeier commented May 13, 2024

To make the situation clearer, here's a screenshot before this PR:

previous screenshot

... and here's how it looks like after this PR:

image

Note that the huge screen is supposed to show the left menu-bar by default, while the medium and small screens don't show it.

@pradyunsg pradyunsg merged commit c7cc10e into sphinx-themes:master May 13, 2024
2 checks passed
@mgeier
Copy link
Contributor Author

mgeier commented May 15, 2024

Thanks!

@mgeier mgeier deleted the load-after-resize branch May 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants