Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yaml to use newer pre-commit version, v3.0.0 #130

Closed
wants to merge 2 commits into from

Conversation

shirou
Copy link
Contributor

@shirou shirou commented Mar 23, 2023

No description provided.

@shirou
Copy link
Contributor Author

shirou commented Mar 23, 2023

https://github.com/pre-commit/action/tree/main

this action is in maintenance-only mode and will not be accepting new features.
generally you want to use pre-commit.ci which is faster and has more features.

hmm. Should we stop using this action? or move to pre-commit.ci?

@pradyunsg
Copy link
Collaborator

@shirou I've filed #131 to fix the pre-commit failures. The failure is basically PyCQA/isort#2078 :)

I think adopting pre-commit.ci isn't strictly necessary but if you think that's preferable, please feel welcome to add that! We should remove the pre-commit CI job then and change the required checks to require pre-commit.ci's check instead of the current pre-commit check from GitHub Actions.

@shirou
Copy link
Contributor Author

shirou commented Mar 24, 2023

fixed by #131

@shirou shirou closed this Mar 24, 2023
@shirou shirou deleted the feature/update_github_actions branch March 24, 2023 13:25
@shirou
Copy link
Contributor Author

shirou commented Mar 24, 2023

I think no need to move to pre-commit.ci. (sorry for pre-commit authors). And since github actions now work due to your excellent PR #131, I'm happy to keep it the way it is for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants