Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multi-function declaration in Python domain has cramped vertical spacing in latexpdf output (#9940) #9941

Merged
merged 4 commits into from Dec 11, 2021

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Dec 5, 2021

Avoid \pysiglinewithargsret tricks to get correct vertical spacing
in multiline declarations in case mark-up inserts a \phantomsection.

Activate such tricks also in \pysigline, but now with the
\phantomsection test.

Fix #9940

Before:

Capture d’écran 2021-12-05 à 15 55 22

After:

Capture d’écran 2021-12-05 à 15 34 00

Relates #7241, #8980, #8995, #9924 (comment)

@jfbu jfbu modified the milestones: 4.3.2, 4.4.0 Dec 5, 2021
Fix sphinx-doc#9940

Avoid \pysiglinewithargsret tricks to get correct vertical spacing
in multiline declarations in case mark-up inserts a \phantomsection.

Activate such tricks also in \pysigline, but now with the
\phantomsection test.

Relates sphinx-doc#7241, sphinx-doc#8980, sphinx-doc#8995
@jfbu jfbu force-pushed the 9940_pymultifunction_latex branch from c83bc37 to 091c2de Compare December 9, 2021 17:31
@jfbu jfbu changed the base branch from 4.3.x to 4.x December 9, 2021 17:31
@jfbu
Copy link
Contributor Author

jfbu commented Dec 9, 2021

Rebased onto 4.x

@jfbu jfbu modified the milestones: 4.4.0, 4.3.2 Dec 9, 2021
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

CHANGES Outdated Show resolved Hide resolved
@tk0miya
Copy link
Member

tk0miya commented Dec 11, 2021

👍

@jfbu jfbu merged commit 20732a3 into sphinx-doc:4.x Dec 11, 2021
@jfbu jfbu deleted the 9940_pymultifunction_latex branch December 11, 2021 19:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-function declaration in Python domain has cramped vertical spacing in latexpdf output
2 participants