New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of local paths in html_logo/html_favicon directorives in conf.py #9440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But this should be rebased onto 4.1.x branch. Could you update this please? Then, I'll merge this soon.
Sure! Well, hmm, it seems that it's already on 4.1.x: $ git rev-parse origin/4.1.x
3c3a734b97c99a9f2b32bd33f7b98921d9da294f
$ git rebase origin/4.1.x
Current branch logo-regression-fix is up to date. I think I may have accidentally just set the target branch incorrectly on this merge request %-) |
This PR contains the CHANGES entry for 4.2.0. I guess you created a commit on the 4.x branch.
Thanks, |
… conf.py Merge request sphinx-doc#9381 broke support for local logos/favicons as it retained the paths that are passed to the template engine. That's wrong as the actual path will be in _static/. This should fix sphinx-doc#9438
efb7757
to
3a50abc
Compare
Ooops, indeed, that explains it. Ok, rebased and force-pushed. I hope it's correct now :) |
Thank you for quick update! |
Merge request #9381 broke support for local logos/favicons as it
retained the paths that are passed to the template engine. That's wrong
as the actual path will be in _static/.
This should fix #9438