Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release of Sphinx by forcing upgrades to dependencies #9439

Closed
wants to merge 2 commits into from
Closed

Fix release of Sphinx by forcing upgrades to dependencies #9439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9daed9f
Bump version
tk0miya Jul 11, 2021
fef4826
Fix release of Sphinx by forcing upgrades to dependencies
ericholscher Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGES
View file
Open in desktop
@@ -1,3 +1,24 @@
Release 4.2.0 (in development)
==============================

Dependencies
------------

Incompatible changes
--------------------

Deprecated
----------

Features added
--------------

Bugs fixed
----------

Testing
--------

Release 4.1.1 (in development)
==============================

Expand Down
12 changes: 6 additions & 6 deletions setup.py
View file
Open in desktop
Expand Up @@ -15,12 +15,12 @@
sys.exit(1)

install_requires = [
'sphinxcontrib-applehelp',
'sphinxcontrib-devhelp',
'sphinxcontrib-jsmath',
'sphinxcontrib-htmlhelp',
'sphinxcontrib-serializinghtml',
'sphinxcontrib-qthelp',
'sphinxcontrib-applehelp>=1.0.2',
'sphinxcontrib-devhelp>=1.0.2',
'sphinxcontrib-jsmath>=1.0.1',
'sphinxcontrib-htmlhelp>=2.0.0',
'sphinxcontrib-serializinghtml>=1.1.5',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's enough to pin only htmlhelp and serializinghtml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we should pin them all, so that we don't hit this issue in the future? I imagine there will also be breaking changes over time, and we want users to have the latest version. I don't feel strongly though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1: too strict

'sphinxcontrib-qthelp>=1.0.3',
'Jinja2>=2.3',
'Pygments>=2.0',
'docutils>=0.14,<0.18',
Expand Down
6 changes: 3 additions & 3 deletions sphinx/__init__.py
View file
Open in desktop
Expand Up @@ -27,8 +27,8 @@
warnings.filterwarnings('ignore', "'U' mode is deprecated",
DeprecationWarning, module='docutils.io')

__version__ = '4.1.1+'
__released__ = '4.1.1' # used when Sphinx builds its own docs
__version__ = '4.2.0+'
__released__ = '4.2.0' # used when Sphinx builds its own docs

#: Version info for better programmatic use.
#:
Expand All @@ -38,7 +38,7 @@
#:
#: .. versionadded:: 1.2
#: Before version 1.2, check the string ``sphinx.__version__``.
version_info = (4, 1, 1, 'beta', 0)
version_info = (4, 2, 0, 'beta', 0)

package_dir = path.abspath(path.dirname(__file__))

Expand Down