Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #9418: Fix missing bracket for empty Callable annotations. #9427

Closed
wants to merge 1 commit into from
Closed

Closes #9418: Fix missing bracket for empty Callable annotations. #9427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES
View file
Open in desktop
Expand Up @@ -16,6 +16,9 @@ Features added
Bugs fixed
----------

* #9418: a Callable annotation with no parameters (e.g. Callable[[], None]) will
be rendered with a bracket missing (Callable[], None])

Testing
--------

Expand Down
12 changes: 8 additions & 4 deletions sphinx/domains/python.py
View file
Open in desktop
Expand Up @@ -129,10 +129,14 @@ def unparse(node: ast.AST) -> List[Node]:
return unparse(node.value)
elif isinstance(node, ast.List):
result = [addnodes.desc_sig_punctuation('', '[')]
for elem in node.elts:
result.extend(unparse(elem))
result.append(addnodes.desc_sig_punctuation('', ', '))
result.pop()
if node.elts:
# check if there are elements in node.elts to only pop the
# last element of result if the for-loop was run at least
# once
for elem in node.elts:
result.extend(unparse(elem))
result.append(addnodes.desc_sig_punctuation('', ', '))
result.pop()
result.append(addnodes.desc_sig_punctuation('', ']'))
return result
elif isinstance(node, ast.Module):
Expand Down