Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8880: viewcode: ExtensionError is raised on incremental build #8891

Closed

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 15, 2021

Feature or Bugfix

  • Bugfix

Purpose

  • viewcode causes ExtensionError on incremental build after unparsable
    python module found for the document on the past build.
  • Internally, False is stored into env._viewcode_modules[modname] for
    the modules that failed to parse on the past build. But env-purge-doc
    does not handle them.
  • refs: Extension error (sphinx.ext.viewcode) with Sphinx 3.5 #8880

…l build

viewcode causes ExtensionError on incremental build after unparsable
python module found for the document on the past build.

Internally, `False` is stored into `env._viewcode_modules[modname]` for
the modules that failed to parse on the past build.  But `env-purge-doc`
does not handle them.
@tk0miya tk0miya added this to the 3.5.1 milestone Feb 15, 2021
@tk0miya
Copy link
Member Author

tk0miya commented Feb 15, 2021

Oops... this is a duplicated with #8888....

@tk0miya tk0miya closed this Feb 15, 2021
@tk0miya tk0miya deleted the 8880_viewcode_Extension_error branch February 15, 2021 14:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant