Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autodoc: check whether __slots__ is a str #8338

Merged
merged 2 commits into from Oct 25, 2020
Merged

autodoc: check whether __slots__ is a str #8338

merged 2 commits into from Oct 25, 2020

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Oct 24, 2020

Closes #8294.

@tk0miya tk0miya added this to the 3.3.0 milestone Oct 25, 2020
tk0miya
tk0miya requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge this soon if you'll add a testcase for this.

@mgeier
Copy link
Contributor Author

mgeier commented Oct 25, 2020

Done: 82c83ed

@tk0miya tk0miya merged commit 9188cba into sphinx-doc:3.x Oct 25, 2020
@tk0miya
Copy link
Member

tk0miya commented Oct 25, 2020

Thank you for your quick work. Merged!

tk0miya added a commit that referenced this pull request Oct 25, 2020
@tk0miya
Update CHANGES for PR #8338
ad7c09e
@mgeier mgeier deleted the autodoc-slots-str branch October 25, 2020 10:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tk0miya tk0miya tk0miya requested changes

Assignees
No one assigned
Labels
extensions:autodoc type:bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

autodoc: single-string __slots__ is not handled correctly
2 participants
@mgeier @tk0miya