Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove rst_epilog from test-root/conf.py #8295

Merged
merged 1 commit into from Oct 24, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Oct 5, 2020

Feature or Bugfix

  • Refactoring

Purpose

  • refs: Don't remove substitution_reference nodes (fix #7953) #8183 (comment)
  • I found test-root defines rst_epilog in its conf.py. It causes
    side-effects to many test cases in Sphinx's testing because test-root
    is widely used. This removes the configuration from test-root not to
    cause side-effects to our testings.
  • Note: We already have test cases for rst_epilog in test_util_rst.

I found test-root defines rst_epilog in its conf.py.  It causes
side-effects to many test cases in Sphinx's testing because test-root
is widely used.  This removes the configuration from test-root not to
cause side-effects to our testings.

Note: We already have test cases for rst_epilog in test_util_rst.
@tk0miya tk0miya added this to the 3.3.0 milestone Oct 5, 2020
@tk0miya tk0miya merged commit 6e1c78f into sphinx-doc:3.x Oct 24, 2020
@tk0miya tk0miya deleted the refactor_root branch October 24, 2020 11:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant