Fix #8157: autodoc: TypeError is raised when annotation has invalid __args__ #8264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
8157_TypeError_for_invalid_args
branch
3 times, most recently
from
eee1557
to
8268e69
Compare
… invalid __args__ Typically, the __args__ attribute of type annotations is a tuple containing arguments for the types (ex. The __args__ of `List[int]` is `(int,)`). But some kind of types has non tuple __args__ attribute. For example, `nptyping.NDArray` is one of them. This fixes the TypeError when the invalid __args__ attribute found.
tk0miya
force-pushed
the
8157_TypeError_for_invalid_args
branch
from
8268e69
to
9a0a0f9
Compare
tk0miya
commented
Oct 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
refs: TypeError: 'type' object is not iterable #8157
Typically, the args attribute of type annotations is a tuple
containing arguments for the types (ex. The args of
List[int]is(int,)). But some kind of types has non tuple args attribute.For example,
nptyping.NDArrayis one of them.This fixes the TypeError when the invalid args attribute found.