New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to MathJax 3. #7961
Move to MathJax 3. #7961
Conversation
According to https://caniuse.com/#feat=es6, ES6 is supported by 96.71% of users' browsers. Maybe the polyfill is not needed? |
Co-authored-by: Dmitry Shachnev <mitya57@users.noreply.github.com>
How about adding |
This is already possible just by switching the |
Indeed. Please forget. I'm afraid to introduce a breaking change in 4.0. But I understand it is hard to reduce the impact (mainly for mathjax customized users). So +1 for this change. |
Is this done? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mitya57 Do you have any comments?
I'm not sure how to get the line length down while keeping the link. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, otherwise it looks good to me.
Co-authored-by: Dmitry Shachnev <mitya57@users.noreply.github.com>
Now I updated a linter rule on #8002. Could you merge the 3.x branch and fold the line before an URL? It allows a very long literal string. |
There are a bunch of merge conflicts I'm not skillful enough to resolve... Should I cherry-pick the commit? |
Oh, sorry. Please wait a moment. I'll merge in into master branch. |
Done. Please merge the master branch into this. |
Thank you for your contribution! Merged 🎉 |
Subject: Move to MathJax 3 in Sphinx 4.0
Feature or Bugfix
Purpose
To use MathJax 3 and all its new features.
Relates
Closes #7425