Do not emit type arguments twice #7569
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
fix-bad-stringify
branch
from
a881fd2
to
b7a7360
Compare
eric-wieser
force-pushed
the
fix-bad-stringify
branch
from
b7a7360
to
4637272
Compare
|
Ping @tk0miya, CI passes now - sorry for not letting you know I was working on the same thing as you before you spent the time! |
|
Don't mind. I feel your implementation is much better than mine :-) |
|
oh, I did not noticed the target branch is 3.0.x. |
tk0miya
added a commit
that referenced
this pull request
Apr 27, 2020
|
Whoops, sorry about that. |
tk0miya
added a commit
that referenced
this pull request
Apr 27, 2020
|
don't mind! I think this is not a critical, but stable. |
|
I assume this will end up in 3.1.0 as well? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7567
Feature or Bugfix