Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Subject: Enable secure object inspection in autodoc'd modules.
Purpose
Inspecting objects in user modules can be risky if they raise errors in their
__getattr__
implementations. One such case is theflask.request
proxy which will complain about not being in a valid context if is accessed in any way and throws aRuntimeError
.Detail
I just wrapped the access in a catchall, since users can raise whatever Exception they want. Maybe
BaseException
/a bareexcept
would be even better, but it seemed risky to includeSystemExit
.Relates
#7516