Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7479: autodoc: Sphinx builds has been slower since 3.0.0 #7504

Merged
merged 1 commit into from Apr 19, 2020

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Apr 18, 2020

Feature or Bugfix

  • Bugfix

Purpose

Call inspect.unwrap() for Mocked objects and modules causes
deep recurrsion calls. As a result, it causes slow builds. This
skips to try documenting mocked objects on filtering members.

refs: #7479

sphinx/ext/autodoc/mock.py Outdated Show resolved Hide resolved
Call ``inspect.unwrap()`` for Mocked objects and modules causes
deep recurrsion calls. As a result, it causes slow builds.  This
skips to try documenting mocked objects on filtering members.
@tk0miya tk0miya force-pushed the 7479_mock_causes_slow_builds branch from 9d1ffa1 to e9b6437 Compare April 19, 2020 05:46
@tk0miya tk0miya merged commit 7a7c38e into sphinx-doc:3.x Apr 19, 2020
@tk0miya tk0miya deleted the 7479_mock_causes_slow_builds branch April 19, 2020 05:54
@tk0miya
Copy link
Member Author

tk0miya commented Apr 19, 2020

Oh, I choose the wrong branch for this PR. cherry-picked this manually into 3.0.x branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant