Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
The 3.0 version of the C domain got more strict, resulting in warnings for declarations that are not technically C, but are rather common, so it would be nice to release this PR soon.
Purpose
Parse attributes in declarations and allow users to define their own identifiers to be parsed as attributes (e.g., when the actual attribute is hidden behind a macro). For example:
Here the
LIGHTGBM_C_EXPORT
identifier is a macro that expands to a symbol visibility attribute.Relates