Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7106: std domain: enumerated nodes are marked as duplicated #7107

Merged
merged 2 commits into from Feb 9, 2020
Merged

Fix #7106: std domain: enumerated nodes are marked as duplicated #7107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f21a12
Fix #7106: std domain: enumerated nodes are marked as duplicated
tk0miya Feb 7, 2020
3ad137b
Merge branch '2.0' into 7106_enumerated_nodes_marked_as_duplicated
tk0miya Feb 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES
View file
Open in desktop
Expand Up @@ -89,6 +89,8 @@ Bugs fixed
modifier keys are ignored, which means the feature can interfere with browser
features
* #7090: std domain: Can't assign numfig-numbers for custom container nodes
* #7106: std domain: enumerated nodes are marked as duplicated when extensions
call ``note_explicit_target()``
* #7095: dirhtml: Cross references are broken via intersphinx and ``:doc:`` role

Testing
Expand Down
4 changes: 3 additions & 1 deletion sphinx/transforms/__init__.py
View file
Open in desktop
Expand Up @@ -173,7 +173,9 @@ def apply(self, **kwargs: Any) -> None:
domain = self.env.get_domain('std') # type: StandardDomain

for node in self.document.traverse(nodes.Element):
if domain.is_enumerable_node(node) and domain.get_numfig_title(node) is not None:
if (domain.is_enumerable_node(node) and
domain.get_numfig_title(node) is not None and
node['ids'] == []):
self.document.note_implicit_target(node)


Expand Down