Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of sectioning (DO NOT MERGE) #7004

Closed
wants to merge 1 commit into from

Conversation

rscohn2
Copy link
Contributor

@rscohn2 rscohn2 commented Jan 9, 2020

Subject: option to add TOC entry for function, class, etc

Feature or Bugfix

  • Feature

Purpose

I am seeking comments on API and implementation and do not expect the PR to be merged in its current form.

Some things that are missing:

  • method to apply it to groups of definitions without explicitly adding :section: to each
    My hope is to add the same option to doxygengroup in breathe and have it generate :section: for
    every entry. A config variable would also be useful.
  • call the option :section: or :toc:?
  • Section name is full signature. Need to make it match the index name
  • Understanding of what should happen for nested objects
  • probably more ...

I added a few sentences to the sphinx documentation to explain how it is used.

Thanks to @melvinvermeeren & @jakobandersen for their help so far.


fun1
-----
.. cpp::function int fun1(int a)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is your goal to make a section or to put this function to ToC? I thought former one is not a goal of users. So it is better to implement latter way.

BTW, I feel a bit strange to add new options to object-description directives. The responsibility of them is to describe what the object is. So -1 for add option to here. How about adding a new config value instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is to put the function in the TOC. I will look at doing it directly instead of creating the section.

I am working on a big doc with multiple parts so having a single global config would not work. There needs to be a way to turn on the option for a region of the doc, but not all.

Closing the pull request while I investigate some more

@rscohn2 rscohn2 closed this Feb 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants