Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch intersphinx inventories concurrently #6825

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

Zac-HD
Copy link
Contributor

@Zac-HD Zac-HD commented Nov 15, 2019

This patch modifies the Intersphinx extension to fetch each inventory - an operation that often means downloading it from the web - in parallel using a concurrent.futures.ThreadPoolExecutor().

Closes #6818, and makes a clean build of Hypothesis' docs build roughly 2x faster 馃槃

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #6825 into 2.0 will increase coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0    #6825      +/-   ##
==========================================
+ Coverage   83.74%   83.74%   +<.01%     
==========================================
  Files         271      271              
  Lines       41188    41194       +6     
  Branches     6010     6011       +1     
==========================================
+ Hits        34492    34498       +6     
  Misses       5366     5366              
  Partials     1330     1330
Impacted Files Coverage 螖
sphinx/ext/intersphinx.py 89.02% <94.11%> (+0.28%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8f554c4...ea3ba6c. Read the comment docs.

@tk0miya tk0miya added type:enhancement enhance or introduce a new feature extensions labels Nov 15, 2019
@tk0miya tk0miya added this to the 2.3.0 milestone Nov 15, 2019
Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@tk0miya tk0miya merged commit 96e60df into sphinx-doc:2.0 Nov 15, 2019
@tk0miya
Copy link
Member

tk0miya commented Nov 15, 2019

Thank you for your contribution!

@Zac-HD Zac-HD deleted the intersphinx-fetch branch November 21, 2019 07:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants