Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext: Use template file to generate message catalog #6802

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Nov 7, 2019

Feature or Bugfix

  • Refactoring

Purpose

@tisonkun
Copy link

Thanks for opening this pull request @tk0miya . Unfortunately I can hardly review the change set without learning how the framework works. But I think I'm able to help with verify the result if you ask for :-)

@tk0miya
Copy link
Member Author

tk0miya commented Nov 14, 2019

@tisonkun Thank you for comment. Don't mind. This is a mere refactoring change. I'll work for your problem in next step. Please help me in that time if needed :-)

@tk0miya tk0miya merged commit 8f554c4 into sphinx-doc:2.0 Nov 14, 2019
@tk0miya tk0miya deleted the 6781_gettext_template branch November 14, 2019 17:33
@jfbu
Copy link
Contributor

jfbu commented Nov 15, 2019

@tk0miya It seems test_gettext_dont_rebuild_mo test fails on 2.0 branch is it related to this changeset?

@tk0miya
Copy link
Member Author

tk0miya commented Nov 15, 2019

No, it is related with this. It might be related with timestamp system of windows.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants