Fixes #6759: validation of html static paths and extra paths no longe… #6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2019 08:58
…s no longer throws an error if the paths are in different directories
Codecov Report
@@ Coverage Diff @@
## master #6765 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 266 267 +1
Lines 40474 40497 +23
Branches 5934 5937 +3
==========================================
+ Hits 34170 34187 +17
- Misses 4997 5000 +3
- Partials 1307 1310 +3
Continue to review full report at Codecov.
|
added 4 commits
October 24, 2019 09:58
|
Now I'm preparing to merge this into 2.2.1 branch on #6774. |
|
I finished to merge this into 2.2.1 branch now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r throws an error if the paths are in different directories
Subject: Reimplement behavior from 2.1.2
Feature or Bugfix
Purpose
See my issue created. Hopefully I'm doing this right, this is my first pull request, kinda nervous
Detail
In essence, the sys.path.commonpath function throws a Value Error if the paths are in different drives. Sphinx has previously had no issue writing to a different drive than the source, but this validation step throws an error. Now, if the drives are different, the error is caught. Since the purpose of the function was to check if the source and static directories was the same, it would evaluate to True if commonpath didn't raise an error.
Relates