Add latexpdf support for Greek as main language (via xelatex use) #6711
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.2.1 #6711 +/- ##
==========================================
+ Coverage 83.78% 83.78% +<.01%
==========================================
Files 269 269
Lines 40970 40981 +11
Branches 5998 5999 +1
==========================================
+ Hits 34325 34336 +11
Misses 5321 5321
Partials 1324 1324
Continue to review full report at Codecov.
|
|
I have squashed the commits. Python 3.6 mypy testing fails for reasons unrelated to this PR. |
| Use ``xelatex`` (and LaTeX package ``xeCJK``) by default for Chinese | ||
| documents. | ||
|
|
||
| .. versionchanged:: 2.2.1 |
There was a problem hiding this comment.
Now, we are using x.y.Z branch for urgent bugfix release. I think 2.0 branch is appropriate for this fix.
There was a problem hiding this comment.
Ah, sorry. I just read #6710 and understand this is a bug. Okay, go with 2.2.1.
sphinx/builders/latex/__init__.py
Outdated
| @@ -418,6 +418,8 @@ def default_latex_engine(config: Config) -> str: | |||
| return 'platex' | |||
| elif (config.language or '').startswith('zh'): | |||
| return 'xelatex' | |||
| elif (config.language or '') == 'el': | |||
There was a problem hiding this comment.
or '' is not needed for this case. It is useful to call methods of string object even if config.language is None. But this line simply compares with string.
There was a problem hiding this comment.
blindly copying pasting is fine, but thinking is better, thanks for the explanation :) will fix
I fixed the error in latest 2.2.1 branch today. Please merge it into this. Then error will go away. |
|
Thanks for reviewing @tk0miya now merging into 2.2.1 |
Closes: #6710
Feature or Bugfix