Fix field lists after switch to HTML5 writer #6625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobandersen
force-pushed
the
6604_field_list_rendering
branch
from
e3b6d01
to
d998fae
Compare
- classic: Put the pink'ish colour back on the field type part (dt). - basic: remove top margin on the field data to align with the type. - basic: use grid display instead of flexbox to avoid fixed width on the field type part. Other themes affected/fixed due to changes in basic: - bizstyle (only technically, it already was fixed in sphinx-doc#6262) - haiku - classic - nature - pyramid - sphinxdoc Fixes sphinx-doc#6604
jakobandersen
force-pushed
the
6604_field_list_rendering
branch
from
d998fae
to
9dd7688
Compare
Codecov Report
@@ Coverage Diff @@
## 2.0 #6625 +/- ##
==========================================
- Coverage 83.77% 83.74% -0.03%
==========================================
Files 266 268 +2
Lines 40916 40950 +34
Branches 5996 5999 +3
==========================================
+ Hits 34277 34294 +17
- Misses 5317 5331 +14
- Partials 1322 1325 +3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Subject: fix HTML rendering of field lists after original switch to the HTML5 writer
Purpose
See #6604. There was a general problem with alignment between dt dd elements, i.e., field type and field content. The classic theme additionally was missing some colour.
Themes affected/fixed due to changes in basic:
See field_lists.zip for screen shots of for version 1.8, 2.13, and with this PR.
Note that both haiku and pyramid still has some alignment problems, though the seem to be present in 1.8 as well.
Relates
Fixes #6604
Perhaps fixes sympy/sympy#16585