Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6245: circular import error on importing SerializingHTMLBuilder #6249

Merged
merged 1 commit into from Apr 4, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Apr 4, 2019

@tk0miya tk0miya added this to the 2.0.1 milestone Apr 4, 2019
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #6249 into 2.0.1 will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.0.1    #6249      +/-   ##
==========================================
- Coverage   83.54%   83.51%   -0.03%     
==========================================
  Files         272      274       +2     
  Lines       39354    39391      +37     
  Branches     5868     5871       +3     
==========================================
+ Hits        32879    32899      +20     
- Misses       5126     5140      +14     
- Partials     1349     1352       +3
Impacted Files Coverage Δ
sphinx/builders/html.py 81.78% <100%> (-0.03%) ⬇️
sphinx/builders/dirhtml.py 92.59% <100%> (+0.59%) ⬆️
sphinx/builders/singlehtml.py 93.51% <100%> (+0.12%) ⬆️
sphinx/__init__.py 73.91% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34302a...9dfbfbf. Read the comment docs.

@tk0miya tk0miya merged commit 8925358 into sphinx-doc:2.0.1 Apr 4, 2019
@tk0miya tk0miya deleted the 6245_circular_import branch April 4, 2019 16:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant