Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6136: :name: option for math directive causes a crash #6137

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Mar 5, 2019

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 1.8.5 milestone Mar 5, 2019
@tk0miya tk0miya force-pushed the 6136_math_name_causes_crash branch from f12b5d9 to 346d33b Compare March 5, 2019 16:46
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #6137 into 1.8 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #6137      +/-   ##
==========================================
- Coverage   82.14%   82.14%   -0.01%     
==========================================
  Files         301      301              
  Lines       40323    40325       +2     
  Branches     6231     6231              
==========================================
+ Hits        33124    33125       +1     
  Misses       5819     5819              
- Partials     1380     1381       +1
Impacted Files Coverage Δ
sphinx/directives/patches.py 91.57% <100%> (+0.18%) ⬆️
sphinx/builders/html.py 82.85% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be971c6...346d33b. Read the comment docs.

@tk0miya tk0miya merged commit 99932ac into sphinx-doc:1.8 Mar 6, 2019
@tk0miya tk0miya deleted the 6136_math_name_causes_crash branch March 6, 2019 16:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant