Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6019: imgconverter: Including multipage PDF fails #6071

Merged
merged 1 commit into from Feb 16, 2019

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Feb 13, 2019

Feature or Bugfix

  • Bugfix

Purpose

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #6071 into 1.8 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #6071      +/-   ##
==========================================
+ Coverage   82.13%   82.14%   +<.01%     
==========================================
  Files         301      307       +6     
  Lines       40294    40632     +338     
  Branches     6225     6278      +53     
==========================================
+ Hits        33096    33376     +280     
- Misses       5819     5871      +52     
- Partials     1379     1385       +6
Impacted Files Coverage Δ
sphinx/ext/imgconverter.py 56.66% <100%> (+2.56%) ⬆️
sphinx/make_mode.py 0% <0%> (ø)
sphinx/search/__init__.py 96.9% <0%> (ø)
sphinx/quickstart.py 0% <0%> (ø)
sphinx/errors.py 80% <0%> (ø)
sphinx/__init__.py 60% <0%> (ø)
sphinx/apidoc.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c3c4a...4adcb40. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #6071 into 1.8 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #6071      +/-   ##
==========================================
+ Coverage   82.13%   82.14%   +<.01%     
==========================================
  Files         301      307       +6     
  Lines       40294    40632     +338     
  Branches     6225     6278      +53     
==========================================
+ Hits        33096    33376     +280     
- Misses       5819     5871      +52     
- Partials     1379     1385       +6
Impacted Files Coverage Δ
sphinx/ext/imgconverter.py 56.66% <100%> (+2.56%) ⬆️
sphinx/make_mode.py 0% <0%> (ø)
sphinx/search/__init__.py 96.9% <0%> (ø)
sphinx/quickstart.py 0% <0%> (ø)
sphinx/errors.py 80% <0%> (ø)
sphinx/__init__.py 60% <0%> (ø)
sphinx/apidoc.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c3c4a...4adcb40. Read the comment docs.

@tk0miya tk0miya merged commit 74ec98b into sphinx-doc:1.8 Feb 16, 2019
@tk0miya tk0miya deleted the 6019_imgconverter_multipaged_PDF branch February 16, 2019 15:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant