Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: use \small fontsize in code-blocks with xelatex and lualatex #5768

Merged
merged 1 commit into from Dec 14, 2018

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Dec 13, 2018

Amusingly the character width of FreeFont Mono (now used by xelatex/lualatex) is quite large, a bit like Courier compared to Times, which is used by pdflatex. Thus in my testing it gives better looking result to use \small with these Unicode engines too. Of course if user changes the font setting, it may be needed that he/she uses also 'fvset' key of latex_elements to adjust.

Relates

@jfbu jfbu added this to the 2.0.0 milestone Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #5768 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5768      +/-   ##
==========================================
- Coverage   83.27%   83.24%   -0.03%     
==========================================
  Files         294      296       +2     
  Lines       39577    39614      +37     
  Branches     5878     5881       +3     
==========================================
+ Hits        32959    32978      +19     
- Misses       5257     5272      +15     
- Partials     1361     1364       +3
Impacted Files Coverage Δ
sphinx/writers/latex.py 83.28% <ø> (ø) ⬆️
sphinx/__init__.py 76% <0%> (ø)
sphinx/make_mode.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a40dd9...022fc9d. Read the comment docs.

@jfbu jfbu merged commit ca2ce49 into sphinx-doc:master Dec 14, 2018
@jfbu jfbu deleted the latex_xelatex_fvset_small branch December 15, 2018 10:40
jfbu added a commit that referenced this pull request Dec 20, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant