Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: use lookbehind regex to not match semicolon at start #5577

Closed
wants to merge 1 commit into from

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Oct 30, 2018

Closes: #5576

Here is screen shot of a portion of the index in library.pdf from CPython 3.7 documentation, showing indexing of ; now works:

capture d ecran 2018-10-30 a 23 27 42

I used a look-behind regex as advocated at this stackoverflow answer

Relates

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #5577 into 1.8 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #5577      +/-   ##
==========================================
- Coverage   82.05%   82.05%   -0.01%     
==========================================
  Files         306      300       -6     
  Lines       40388    40049     -339     
  Branches     6241     6187      -54     
==========================================
- Hits        33141    32862     -279     
+ Misses       5862     5809      -53     
+ Partials     1385     1378       -7
Impacted Files Coverage Δ
sphinx/writers/latex.py 84.06% <100%> (ø) ⬆️
sphinx/make_mode.py
sphinx/search/__init__.py
sphinx/quickstart.py
sphinx/errors.py
sphinx/__init__.py
sphinx/apidoc.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d7b2e...ecdf151. Read the comment docs.

@jfbu
Copy link
Contributor Author

jfbu commented Oct 31, 2018

@tk0miya thanks a lot for quick review. I will soon make however another PR to fix #5579 and it fixes the #5576 issue as well. But it is less minimal change.

@jfbu
Copy link
Contributor Author

jfbu commented Nov 6, 2018

This is closed without merging because it got superseded by #5583.

@jfbu jfbu closed this Nov 6, 2018
@jfbu jfbu deleted the 5576_index_sole_semicolon branch December 17, 2018 18:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants