Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5495: csv-table directive with file option in included file is broken #5530

Merged
merged 2 commits into from Oct 14, 2018

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Oct 14, 2018

@tk0miya tk0miya added this to the 1.8.2 milestone Oct 14, 2018
@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #5530 into 1.8 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.8    #5530      +/-   ##
==========================================
- Coverage   82.06%   82.05%   -0.01%     
==========================================
  Files         300      300              
  Lines       40037    40025      -12     
  Branches     6185     6185              
==========================================
- Hits        32855    32843      -12     
  Misses       5804     5804              
  Partials     1378     1378
Impacted Files Coverage Δ
sphinx/directives/other.py 90.38% <100%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9158363...a78cb6f. Read the comment docs.

@tk0miya tk0miya merged commit adf0160 into sphinx-doc:1.8 Oct 14, 2018
@tk0miya tk0miya deleted the 5495_broken_csvtable branch October 14, 2018 15:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant