Revert "Builder.build: save env also with only new documents" #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20f625b, which introduced a regression in dependency tracking for build systems invoking sphinx-build (described in issue sphinx-doc#5501.) The correct solution is to properly track when the pickle file needs to be written; unfortunately I don't know enough about sphinx to implement this. Also, I'm not sure the intersphinx cache belongs into this at all.
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #5524 +/- ##
==========================================
- Coverage 83.1% 83.07% -0.04%
==========================================
Files 289 291 +2
Lines 38818 38855 +37
Branches 5836 5839 +3
==========================================
+ Hits 32260 32279 +19
- Misses 5198 5213 +15
- Partials 1360 1363 +3
Continue to review full report at Codecov.
|
|
I merged #5525 instead of this. It will be merged to master branch later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 20f625b, which
introduced a regression in dependency tracking for build systems
invoking sphinx-build (described in issue #5501.)
The correct solution is to properly track when the pickle file needs to
be written; unfortunately I don't know enough about sphinx to implement
this. Also, I'm not sure the intersphinx cache belongs into this at
all.