Fix #3704: (latex) wrong \label positioning for figures with a legend
#5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.8 #5513 +/- ##
==========================================
+ Coverage 82.07% 82.07% +<.01%
==========================================
Files 306 306
Lines 40364 40366 +2
Branches 6236 6237 +1
==========================================
+ Hits 33128 33131 +3
Misses 5852 5852
+ Partials 1384 1383 -1
Continue to review full report at Codecov.
|
|
Thanks @tk0miya for quick review! merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figures may have a "legend" which may contain arbitrary contents, so
\labelshould be located immediately after\caption, else hyperlink might get wrong target.see #3704 for example of what was wrong