-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qualify attribute names for generated ivar #5129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5129 +/- ##
==========================================
- Coverage 82.31% 82.29% -0.02%
==========================================
Files 297 297
Lines 39212 39223 +11
Branches 6033 6035 +2
==========================================
+ Hits 32276 32279 +3
- Misses 5602 5610 +8
Partials 1334 1334
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I would like to see at least one unit test that exercises the new code. Add a unit test, and I'll approve this!
Thank you very much for refactoring and merging this! |
Subject: Make Napoleon qualify attribute names for generated ivar
Feature or Bugfix
Purpose
This PR gives a partial fix of #4074. I hope this works in the most cases (an exception is the same attribute name in different classes with the same name, in python<3.3).
Detail
For example, the
Attributes
items inwill be treated as
which is converted to
in order to avoid unintended links.
Relates