DEPS: Lazy import defusedxml only when necessary
#12362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import `defusedxml` inside the `etree_parse()` function rather than in global scope of `sphinx.testing.util`. This makes it possible for reverse dependencies (such as `breathe`) to use this module without adding an unnecessary transitive dependency on `defusedxml` when it's not actually used. See also issue sphinx-doc#12339.
|
Yeh I'd agree, but will wait to @picnixz to comment before merging TBH |
chrisjsewell
approved these changes
May 8, 2024
|
Independently on that, I still think that we need to split the dependencies but I think this one is fine enough as a simple patch for now. Also, it reduces the import time so it's an improvement on its own. @chrisjsewell I'll let you merge this one if you want to improve the commit message |
chrisjsewell
changed the title
defusedxml import into the function using itdefusedxml import into the function using it
chrisjsewell
changed the title
defusedxml import into the function using itdefusedxml only when necessary
|
cheers! |
|
Thanks a lot! |
stephenfin
added a commit
to hoodmane/sphinx-click
that referenced
this pull request
May 14, 2024
Until Sphinx v7.3.8 or v7.4.0 is released with [1] included. [1] sphinx-doc/sphinx#12362 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
pushed a commit
to hoodmane/sphinx-click
that referenced
this pull request
May 14, 2024
Until Sphinx cuts a release with [1] included. [1] sphinx-doc/sphinx#12362
stephenfin
added a commit
to click-contrib/sphinx-click
that referenced
this pull request
May 14, 2024
Until Sphinx v7.3.8 or v7.4.0 is released with [1] included. [1] sphinx-doc/sphinx#12362 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
pushed a commit
to click-contrib/sphinx-click
that referenced
this pull request
May 14, 2024
Until Sphinx cuts a release with [1] included. [1] sphinx-doc/sphinx#12362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Move
defusedxmlimport into the function using itFeature or Bugfix
Purpose
Import
defusedxmlinside theetree_parse()function rather than in global scope ofsphinx.testing.util. This makes it possible for reverse dependencies (such asbreathe) to use this module without adding an unnecessary transitive dependency ondefusedxmlwhen it's not actually used.Detail
Relates
defusedxmlbe moved to the runtime dependencies? #12339.