Fix non-translated formatted string in js #12215
Conversation
The formated string was evaluated befor the gettext call, which prevented any translated message from being loaded. Use a plain old string instead and manually replace the text afterwards. Fixes sphinx-doc#12129.
|
This is interesting. Are there other places where JS strings are not correctly localized ? (if so, could you correct them in one PR?) |
I didn't find other places with this problem. But I saw in the generated js translation files that there are some strings with variable replacements using a différent pattern, for example in the french translation's one: sphinx/sphinx/locale/fr/LC_MESSAGES/sphinx.js Lines 4 to 5 in cb8a28d Maybe it would be better to also use the same For now I thought it would be best to keep the string as is, so we don't have to translate it again. |
I'm sorry but I don't see the difference with what you showed (unless you are talking about the copyright line, in which case it appears we just don't translate it at all for now?)
Yes, let's just not change it for now. I was just wondering whether there were other issues similar to what we had. |
|
Thank you! |
The formatted string was evaluated before the gettext call, which prevented any translated message from being loaded. Use a plain old string instead and manually replace the text afterwards.
Fixes #12129
I tried to switch to the supposedly more correct
Document.ngettextfunction by the way, but didn't manage to make it work properly for french plurals. So instead I decided to only fix the original issue. This also allows to reuse the message for languages that have already translated it.