Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fix side-effect due to repeated fields #12187

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 23, 2024

Closes #12121.

The side-effect can be solved in two manners:

  • Remove the duplicated entries in field-role.rst.
  • Assume that semicolon.rst and index.rst were the only files meant to be fixed.

@jayaddison Which one do you prefer (I assumed to only use two files since there are other conflicting entries I think with other pairs of files and at least we know which files are being used).

@jayaddison
Copy link
Contributor

Closes #12121.

The side-effect can be solved in two manners:

* Remove the duplicated entries in `field-role.rst`.

* Assume that `semicolon.rst` and `index.rst` were the only files meant to be fixed.

@jayaddison Which one do you prefer (I assumed to only use two files since there are other conflicting entries I think with other pairs of files and at least we know which files are being used).

I think I prefer the first approach, and the reason: the second case performs a 'different build', doesn't it? (doesn't share the same config)

@picnixz
Copy link
Member Author

picnixz commented Mar 23, 2024

I would also go for the first one, but... we are also suppressing some warnings as well, especially those concerning 'orphan' documents not marked as orphan.

I'll think a bit more (this one is not pressing) about which direction to take (since it could affect other tests using the same files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Test case 'test_domain_cpp_build_semicolon' fails when run individually.
2 participants