Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] linting: share job steps up-to-and-including pip and lint dependency installation. #12175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Purpose

  • By using identical job steps during the creation phases of linting-related jobs, it may be possible (I don't know whether it's implemented in practice) allow GitHub to re-use container images when running the relevant workflows. It's also a little more consistent.

Detail

  • Installation of precise versions of ruff should occur as long as that is what is configured in pyproject.toml.
  • For linting jobs, perform a pip upgrade install, followed by a .[lint] dependency set install.
  • For mypy, where we also want to having typing information for some of the test dependencies, subsequently install those too (. should be detected as already-installed, I think?).

Relates

@jayaddison jayaddison added internals:typing github_actions Pull requests that update GitHub Actions code labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code internals:typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant