New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] add logic for testing sphinx.testing.fixtures
[part 3]
#12106
Open
picnixz
wants to merge
103
commits into
sphinx-doc:master
Choose a base branch
from
picnixz:core/test-plugin-part-3
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #12093.
This adds the tests for testing our plugin implementation.
Due to
xdist
implementation, the collection of test items does not happen on the controller node but only at the level of the worker nodes and each worker node executes the same protocol.Now, if a test is parametrized, it is obvious that we want the tests to be executed by the same worker, hence the needs of
xdist_group
. Unfortunately, you cannot specify the group at the moment a fixture is requested since it will already be too late. Thus, if no explicit group is given, we automatically add a group to parametrized tests based on the location of the "base" node.Note that this feature only affects our internal tests, so downstream repos using the plugin are not affected and should do their own trick for
xdist
(they can use the same approach or do whatever they need manually).