Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetically sort the list of contributors #10671

Merged
merged 1 commit into from Jul 16, 2022

Conversation

pradyunsg
Copy link
Contributor

This matches the language used to describe the listing.

This is basically a reordering of the content. :)

This matches the language used to describe the listing.
@tk0miya tk0miya added this to the 5.1.0 milestone Jul 16, 2022
@tk0miya tk0miya merged commit 93b7031 into sphinx-doc:5.x Jul 16, 2022
@tk0miya
Copy link
Member

tk0miya commented Jul 16, 2022

Thanks!

@pradyunsg pradyunsg deleted the sort-authors-listing branch July 16, 2022 10:22
@AA-Turner
Copy link
Member

AA-Turner commented Jul 16, 2022

@pradyunsg -- it seems the list was previously sorted fairly well by surname, whereas this PR changed it to forename sorting (only the first two & last five entries were incorrect in the 'old' scheme).

If forename sorting is to be the way going forwards, we should update the note. Personally when I see 'sorted alphabetically' with a list of names, I expect surname sorting.

We should also update Jakob to be in the list of co-maintainers.

A

@pradyunsg
Copy link
Contributor Author

pradyunsg commented Jul 17, 2022

Personally when I see 'sorted alphabetically' with a list of names, I expect surname sorting.

Fascinating! (human culture is weird)

I certainly don't understand it that way. I understand it as sorted by names, as they're written. That notably doesn't exclude folks who don't have surnames, which is uncommon but does happen.

None the less, if folks reckon there's value in clarifying this, I'd suggest adding "as written" if it helps disambiguation of what the sort order is (and keeping the current sort order :P).

@AA-Turner
Copy link
Member

Fascinating! (human culture is weird)

Indeed, and I'm perhaps more influenced by the school registers &c of my childhood. I've written a brief PR to clarify the sorting scheme and incidentally to sort the maintainer list.

A

@pradyunsg
Copy link
Contributor Author

x-ref #10676

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants